New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix incorrect usage of clientSettings.path as route #81

Merged

DeborahPereira4sh merged 1 commit into dev from fix/fix-client-path-usage

Jan 30, 2025

Contributor

DeborahPereira4sh commented Jan 30, 2025

clientSettings.path is the client host that is used in the from header of sent OCPP message

If we use clientSettings.path as route, the client will have to send his message to clientSettings.path:clientSettings.port/clientSettings.path. Example: if clientSettings.path = http://localhost and clientSettings.port = 8080 , the client will have to send his messages to http://localhost:8080/http://localhost


          fix: fix incorrect usage of clientSettings.path as route

70492df

DeborahPereira4sh requested review from lilgallon and pbourseau

January 30, 2025 15:08

sonarqubecloud bot commented Jan 30, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Member

lilgallon commented Jan 30, 2025

may fix #53 (comment)

lilgallon approved these changes

View reviewed changes

DeborahPereira4sh merged commit 0e57ed4 into dev

3 checks passed

DeborahPereira4sh deleted the fix/fix-client-path-usage branch

January 30, 2025 15:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet