Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ICINGADB_SLEEP=30 #27

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Introduce ICINGADB_SLEEP=30 #27

wants to merge 4 commits into from

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov self-assigned this Jun 1, 2021
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Jun 1, 2021

Blocked by

@Al2Klimov Al2Klimov mentioned this pull request Jun 1, 2021
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this needs explicit configuration anyways, why not make it a flag that enables or disables automatic schema upgrades altogether? Then it'd also be safe even if they start with unfortunate timing. Could also be something like "check schema version, if it doesn't match, wait some time for it to be applied", so that this wouldn't delay every start.

@Al2Klimov
Copy link
Member Author

Because then the other instance just crashes. (Icinga/icingadb#295)

@julianbrost
Copy link
Contributor

Not if you wait for the schema to be upgraded by the other instance. You have to coordinate upgrades between all instances anyways, you don't want one instance running while the other is upgrading the schema.

I'd still argue for not doing automatic schema upgrades for now. We don't really need it for now (if you use a pre-release version, it's totally acceptable if you have to apply schema migrations yourself) and after we released 1.0, we want to be careful about what schema changes we do anyways as we don't want to break compatibility everywhere all the time. So I'd say it makes much more sense to think about and implement automatic schema upgrades, once we actually have the need for it for production setups and also know the types of schema changes we want to make.

@Al2Klimov Al2Klimov removed their assignment Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants