Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce database.AutoUpgradeSchema() #12

Closed
wants to merge 559 commits into from
Closed

Conversation

Al2Klimov
Copy link
Member

No description provided.

lippserd and others added 30 commits October 13, 2021 09:46
I.e. don't wait for the complete initial sync first.
contracts.EntitiyFactoryFunc.WithInit() checked for
contracts.Initer every time.
Now it is only done once in common.NewSyncSubject().
This also requires explicit handling of custom variables as we need
to multiplex the original values to handle flat custom variables.
….com/goccy/go-yaml

... not to have GPLv2<->Apache 2.0 (app<->deps) license conflicts.
Make {NotificationHistory,StateHistory,History*}#Id UUID -> SHA1
With this change Icinga DB will insert the environment after each
heartbeat takeover if it does not already exist in the database as
the environment may have changed, although this is likely to happen
very rarely,

Instead of checking whether the environment already exists,
uses an INSERT statement that does nothing if it does.
The default environment of Icinga is the empty string.
In Golang, the zero value of string is also the empty string.
But it makes sense to distinguish whether the name is not set
or set to the empty string. That is possible with this change.
If the environment changes during runtime, we have to restart HA
in order to stop a possibly running config sync and start a new
one.
Previously, we selected each entity from the database.
Now we only select entities that belong to the current environment.
Icinga/icinga2#9036 introduced a new environment ID for
Icinga DB that's written to the icinga:stats stream as field
"icingadb_environment". This commit updates the code to make use of this ID
instead of the one derived from the Icinga 2 Environment constant.
There's a small risk that when the environment ID changes, Icinga DB could
update write into the wrong environment in the database. Therefore,
Icinga/icinga2#9036 introduced a new default
environment ID based on the CA public key so that there should be no cases
where it's required to change the actual environment ID. So if this happens
nonetheless, just bail out.
lippserd and others added 24 commits November 21, 2023 13:29
`ColumnMap` provides a cached mapping of structs exported fields to
their database column names. By default, all exported struct fields are
mapped to their database column names using snake case notation. The `-`
(hyphen) directive for the db tag can be used to exclude certain fields.
Since `ColumnMap` uses cache, the returned slice MUST NOT be modified
directly.
database: Introduce `ColumnMap`
Allow to dynamically define type constraint name
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 23, 2024
@Al2Klimov
Copy link
Member Author

@lippserd Does the design look good so far?

@lippserd
Copy link
Member

Main branch was force pushed because the latest version of the Icinga Go library and the library code in the Icinga DB have diverged. Please create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants