Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL/MariaDB set session vars unittests #20

Merged
merged 2 commits into from
Sep 2, 2024
Merged

MySQL/MariaDB set session vars unittests #20

merged 2 commits into from
Sep 2, 2024

Conversation

yhabteab
Copy link
Member

refs #10

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 27, 2024
@yhabteab yhabteab force-pushed the support-set-session-vars branch 6 times, most recently from d7429e7 to 3be6503 Compare May 28, 2024 09:23
@yhabteab yhabteab requested a review from Al2Klimov May 28, 2024 10:30
@yhabteab yhabteab force-pushed the support-set-session-vars branch from 4ec85db to d0abbb0 Compare July 10, 2024 10:50
@yhabteab yhabteab mentioned this pull request Jul 10, 2024
Merged
6 tasks
@yhabteab yhabteab force-pushed the support-set-session-vars branch from 8d6e86c to b1010e4 Compare July 16, 2024 11:45
@yhabteab yhabteab force-pushed the support-set-session-vars branch from b1010e4 to d6ffc35 Compare August 2, 2024 15:40
@yhabteab yhabteab added the tests Adding tests to existing code label Aug 2, 2024
@yhabteab yhabteab force-pushed the support-set-session-vars branch from d6ffc35 to 2c12dc9 Compare August 6, 2024 15:59
julianbrost
julianbrost requested changes Aug 7, 2024
View reviewed changes
database/testutils.go Outdated Show resolved Hide resolved
database/utils.go Outdated Show resolved Hide resolved
database/set_mysql_session_vars_test.go Outdated Show resolved Hide resolved
database/set_mysql_session_vars_test.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the support-set-session-vars branch from 2c12dc9 to efd1513 Compare August 14, 2024 13:10
@yhabteab yhabteab requested a review from julianbrost August 14, 2024 13:15
julianbrost
julianbrost requested changes Aug 19, 2024
View reviewed changes
database/set_mysql_session_vars_test.go Outdated Show resolved Hide resolved
database/utils.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the support-set-session-vars branch from efd1513 to 0c783fc Compare August 26, 2024 07:52
@yhabteab yhabteab requested a review from julianbrost August 26, 2024 07:52
@oxzi oxzi added this to the 0.3.2 milestone Aug 26, 2024
julianbrost
julianbrost requested changes Aug 30, 2024
View reviewed changes
.github/workflows/sql.yml Outdated Show resolved Hide resolved
database/db.go Outdated Show resolved Hide resolved
database/utils_test.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the support-set-session-vars branch from 0c783fc to 89a88c0 Compare September 2, 2024 07:11
@yhabteab yhabteab requested a review from julianbrost September 2, 2024 07:12
@yhabteab yhabteab merged commit 296f480 into main Sep 2, 2024
15 checks passed
@yhabteab yhabteab deleted the support-set-session-vars branch September 2, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al2Klimov Al2Klimov Al2Klimov left review comments

@julianbrost julianbrost julianbrost approved these changes

Assignees

@yhabteab yhabteab

Labels
cla/signed CLA is signed by all contributors of a PR tests Adding tests to existing code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yhabteab @julianbrost @Al2Klimov @oxzi