Introduce DB#ExecTx() method
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
reviewed
Aug 14, 2024
yhabteab
force-pushed
the
run-in-tx-method
branch
from
dcd45ea to
486f869
Compare
oxzi
previously approved these changes
Aug 15, 2024
lippserd
requested changes
Aug 26, 2024
yhabteab
force-pushed
the
run-in-tx-method
branch
from
486f869 to
db40fe1
Compare
yhabteab
force-pushed
the
run-in-tx-method
branch
from
db40fe1 to
f802918
Compare
|
Just fixed the outdated commit message which was referring to the now renamed method |
lippserd
requested changes
Sep 18, 2024
database/db.go
Outdated
| func (db *DB) ExecTx(ctx context.Context, fn func(context.Context, *sqlx.Tx) error) error { | ||
| tx, err := db.BeginTxx(ctx, nil) | ||
| if err != nil { | ||
| return errors.Wrap(err, "cannot start transaction") |
There was a problem hiding this comment.
Sorry to be pedantic but we're using can't instead of cannot everywhere. Same for the other error message.
There was a problem hiding this comment.
Quite ironic that we have replaced all such abbreviations in Icinga Notifications :-)
There was a problem hiding this comment.
I didn't know that :). If we want to use more formal error messages, I have no problem with that. However, we should then change all error messages in the lib.
yhabteab
force-pushed
the
run-in-tx-method
branch
from
f802918 to
29c5d9d
Compare
lippserd
approved these changes
Sep 19, 2024
|
@oxzi do you want to look over the changes again since you previously approved it? |
oxzi
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
DB#ExecTx()method on theDBreceiver (cherry-picked from #18)