Revert "Merge pull request #72 from Icinga/reflectPtr" #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f25f8a0, reversing changes made to a2fd4d4. While the changes relax the necessary checks for passing a valid pointer, they complicate the tests and still allow non-construct pointer types that implement the validator interface to pass. This negates the benefits, making it simpler to validate the pointer argument in a function as previously done.
|
I think // validatorPtr combines the [Validator] interface with a pointer constraint.
type validatorPtr[T ~struct{}] interface {
Validator
*T
}Nevertheless, the tests would have to be adapted, and the non-nil checks can't be removed anyway. |
yhabteab
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f25f8a0, reversing changes made to a2fd4d4.
While the changes relax the necessary checks for passing a valid pointer, they complicate the tests and still allow non-struct pointer types that implement the validator interface to pass. This negates the benefits, making it simpler to validate the pointer argument in a function as previously done.
refs #72