Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly link objects to their source #117

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Conversation

raviks789
Copy link
Contributor

fixes #115

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 14, 2023
@raviks789 raviks789 self-assigned this Sep 14, 2023
@raviks789 raviks789 requested a review from nilmerg September 14, 2023 14:46
@raviks789 raviks789 force-pushed the directly-link-object-source branch from 26ad497 to f5fc30c Compare September 21, 2023 12:55
@yhabteab yhabteab force-pushed the directly-link-object-source branch from f5fc30c to e652b8e Compare September 21, 2023 14:23
@raviks789 raviks789 force-pushed the directly-link-object-source branch from e652b8e to 50bd816 Compare September 21, 2023 14:27
@yhabteab yhabteab force-pushed the directly-link-object-source branch from 50bd816 to 657b698 Compare September 28, 2023 11:06
@yhabteab yhabteab force-pushed the directly-link-object-source branch from 657b698 to cb51e75 Compare September 28, 2023 11:10
@julianbrost
Copy link
Collaborator

From trying out this PR (I haven't looked at the code at all): the incident view now shows all the information I expect with the changes from Icinga/icinga-notifications#98. So from that perspective, the remaining things are more or less cosmetic: that what's already mentioned in #115 (comment), but looking at the following screenshot also makes me ask how useful repeating the same object name and source icon over and over, given everywhere it's shown within one incident, it's the same.

history

@yhabteab yhabteab merged commit 3494c22 into main Sep 28, 2023
@yhabteab yhabteab deleted the directly-link-object-source branch September 28, 2023 12:19
@nilmerg nilmerg added this to the Preview #1 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link objects directly to their sources
4 participants