Flexible id tags #133
Merged
Flexible id tags #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
2 times, most recently
from
bdaa5a6 to
204adf5
Compare
1 task
|
Having this custom tags without the Web renders these entries everywhere as follows: Note: It's a host object not service. Sometimes it uses the |
|
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
from
204adf5 to
5f0a3f9
Compare
nilmerg
requested changes
Oct 16, 2023
library/Notifications/Widget/ItemList/IncidentHistoryListItem.php
Outdated
Show resolved
Hide resolved
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
4 times, most recently
from
62256b1 to
19b5cc8
Compare
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
5 times, most recently
from
e6cf802 to
5b87eaf
Compare
|
I wanted to give this a try, but I only got exceptions on the event and incident detail pages. Event detail: Incident detail: Tried with this PR as is as well as rebased onto main in both the For the parts that I could try, the looks are more, let's say functional:
That should probably receive some nicer styling, however, I don't decide if this is part of the scope of this PR. |
|
Please pull |
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
from
5b87eaf to
7100594
Compare
nilmerg
requested changes
Nov 29, 2023
library/Notifications/Widget/ItemList/IncidentHistoryListItem.php
Outdated
Show resolved
Hide resolved
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
from
6f76fae to
3b120d1
Compare
sukhwinder33445
force-pushed
the
manage-flexible-tag-id
branch
from
3b120d1 to
fb5633b
Compare
nilmerg
approved these changes
Nov 30, 2023
|
|
||
| $relations->belongsTo('source', Source::class)->setJoinType('LEFT'); | ||
| } | ||
|
|
||
| public function getName(): ValidHtml |
There was a problem hiding this comment.
This is subject to change in #132. If there's a need to render a more complex name, it involves changing what's a link and what's not. Hence the hook will be triggered way before this method is being called. So it should be sufficient to return a string here.
| $relation = $isIdTag ? 'object.tag' : 'object.extra_tag'; | ||
| $tagName = $tag->tag; | ||
|
|
||
| yield $relation . '.' . $tagName => $tagName; |
There was a problem hiding this comment.
This should render the label as it's done after the filter has been enriched. i.e. Currently only host is shown. By completing the filter, it changes to Object host. It should be Object host to begin with. Though, I'd rather drop the Object prefix and just capitalize the tag name. Anyway, my main point is, it should not be shown differently in the suggestion list than it's shown after a condition is complete.
| /** @var Query $objectIdTagQuery */ | ||
| $objectIdTagQuery = $this->object_id_tag; | ||
| /** @var ObjectIdTag $id_tag */ | ||
| foreach ($objectIdTagQuery as $id_tag) { |
There was a problem hiding this comment.
This leads to a separate query for tags for each list item. (If this method is called by a list item)
That's rather in-effective and should be avoided. The plan here should be to join the tags in the base query already, group it and aggregate the tag names and values in two separate columns. They can then be split and combined by php, which is still better than issuing multiple additional queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by