Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve longer appointment style #134

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Improve longer appointment style #134

merged 4 commits into from
Apr 18, 2024

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Oct 16, 2023 •
edited
Loading

fixes #129

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 16, 2023
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch from fd0e385 to 69474d3 Compare October 16, 2023 16:03
@raviks789 raviks789 self-assigned this Oct 17, 2023
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 4 times, most recently from d0b737a to 5fded4c Compare October 19, 2023 07:46
@raviks789 raviks789 requested a review from flourish86 October 19, 2023 07:47
@raviks789 raviks789 marked this pull request as ready for review October 19, 2023 07:47
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 13 times, most recently from 8ef929b to afc999a Compare October 23, 2023 08:37
@nilmerg nilmerg added this to the Preview #1 milestone Nov 30, 2023
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 5 times, most recently from 1a3abff to 7b1ffae Compare December 19, 2023 15:01
@raviks789 raviks789 requested a review from nilmerg December 19, 2023 15:07
nilmerg
nilmerg requested changes Mar 28, 2024
View reviewed changes
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 3 times, most recently from f023ae4 to 1ac933c Compare April 2, 2024 14:23
@raviks789 raviks789 requested a review from nilmerg April 2, 2024 14:24
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 4 times, most recently from 9847801 to fb5bf8b Compare April 3, 2024 08:32
nilmerg
nilmerg requested changes Apr 15, 2024
View reviewed changes
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Calendar/BaseGrid.php Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Show resolved Hide resolved
nilmerg
nilmerg reviewed Apr 16, 2024
View reviewed changes
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
public/css/calendar.less Outdated Show resolved Hide resolved
@nilmerg nilmerg force-pushed the improve-longer-appointment-style branch from 0b65f57 to cb9c7fe Compare April 16, 2024 14:39
@nilmerg nilmerg added enhancement New feature or improvement area/ui Affects the user interface labels Apr 16, 2024
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch 2 times, most recently from 62cec55 to 38a4587 Compare April 17, 2024 11:19
@raviks789 raviks789 requested a review from nilmerg April 17, 2024 11:27
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch from 38a4587 to c2f0bbd Compare April 17, 2024 12:49
nilmerg
nilmerg requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

library/Notifications/Widget/Calendar/BaseGrid.php Show resolved Hide resolved
@raviks789 raviks789 force-pushed the improve-longer-appointment-style branch from c2f0bbd to ddef6dd Compare April 18, 2024 08:26
@nilmerg nilmerg merged commit 73ccbc7 into main Apr 18, 2024
22 checks passed
@nilmerg nilmerg deleted the improve-longer-appointment-style branch April 18, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
area/ui Affects the user interface cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

Calendar: Visualize entries with end or start scheduled beyond current view
2 participants
@raviks789 @nilmerg