Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin#ConfigOptions: Remove placeholder and use default instead #142

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Plugin#ConfigOptions: Remove placeholder and use default instead #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/channel/email/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func (ch *Email) GetInfo() *plugin.Info {
"en_US": "From",
"de_DE": "Von",
},
Placeholder: "[email protected]",
Default: "[email protected]",
},
}

Expand Down
5 changes: 1 addition & 4 deletions pkg/plugin/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,10 @@ type ConfigOption struct {
// An "en_US" locale must be given as a fallback
Label map[string]string `json:"label"`

// Element placeholder
Placeholder string `json:"placeholder,omitempty"`

// Element title: When the user moves the mouse pointer over an element, a tooltip is displayed with a given message.
Help map[string]string `json:"help,omitempty"`

// Element default value: bool for checkbox, string for other elements
// Element default: bool for checkbox default value, string for other elements (used as placeholder)
Default any `json:"default,omitempty"`

// Set true if this element is required, omit otherwise
Expand Down