Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing log message fields in systemd journal (bump github.com/icinga/icinga-go-library from 0.3.0 to 0.3.1) #267

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps github.com/icinga/icinga-go-library from 0.3.0 to 0.3.1.

Commits
  • ee07796 Merge pull request #48 from Icinga/fix-syslog-identifier-for-journald
  • 3f3ec3a logging: Sanitize Journald Field Key Names
  • 23a1e76 Merge pull request #24 from Icinga/test-String
  • 7869494 Merge pull request #28 from Icinga/test-Name
  • 343604f Merge pull request #30 from Icinga/test-Bool
  • 23ac789 Merge pull request #29 from Icinga/test-Binary
  • 51678d0 Merge pull request #26 from Icinga/test-Int
  • 8c04ed8 Merge pull request #25 from Icinga/test-UUID
  • 72ab1a1 Merge pull request #31 from Icinga/types-receivers
  • 9cd1979 Merge pull request #37 from Icinga/simplify-com
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

fixes #264

Bumps [github.com/icinga/icinga-go-library](https://github.com/icinga/icinga-go-library) from 0.3.0 to 0.3.1.
- [Commits](Icinga/icinga-go-library@v0.3.0...v0.3.1)

---
updated-dependencies:
- dependency-name: github.com/icinga/icinga-go-library
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 29, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 29, 2024
@julianbrost julianbrost changed the title build(deps): bump github.com/icinga/icinga-go-library from 0.3.0 to 0.3.1 Fix missing log message fields in systemd journal (bump github.com/icinga/icinga-go-library from 0.3.0 to 0.3.1) Jul 29, 2024
@julianbrost julianbrost added the bug Something isn't working label Jul 29, 2024
@julianbrost julianbrost requested review from julianbrost and oxzi July 29, 2024 11:55
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, the systemd journal now receives the ICINGA_NOTIFICATIONS_* fields as expected (lines sorted by key for clarity):

{
        "ICINGA_NOTIFICATIONS_CONTACT" : "Admin",
        "ICINGA_NOTIFICATIONS_EVENT_TYPE" : "state",
        "ICINGA_NOTIFICATIONS_INCIDENT" : "#12547",
        "ICINGA_NOTIFICATIONS_OBJECT" : "jb-d12!random0",
        "ICINGA_NOTIFICATIONS_TYPE" : "webhook",
        "MESSAGE" : "incident: Successfully sent a notification via channel plugin",
        "PRIORITY" : "6",
        "SYSLOG_IDENTIFIER" : "icinga-notifications",
        "_BOOT_ID" : "f74ea6b780ab457aa78b2588f84dccef",
        "_CAP_EFFECTIVE" : "0",
        "_CMDLINE" : "/usr/sbin/icinga-notifications",
        "_COMM" : "icinga-notifica",
        "_EXE" : "/usr/sbin/icinga-notifications",
        "_GID" : "113",
        "_HOSTNAME" : "jb-d12",
        "_MACHINE_ID" : "c8e230a4abf54885a3be78a5a0317b59",
        "_PID" : "441089",
        "_RUNTIME_SCOPE" : "system",
        "_SELINUX_CONTEXT" : "unconfined\n",
        "_SOURCE_REALTIME_TIMESTAMP" : "1722255159867454",
        "_SYSTEMD_CGROUP" : "/system.slice/icinga-notifications.service",
        "_SYSTEMD_INVOCATION_ID" : "38f0e592ce1d4e13b797f165d5aad8ab",
        "_SYSTEMD_SLICE" : "system.slice",
        "_SYSTEMD_UNIT" : "icinga-notifications.service",
        "_TRANSPORT" : "journal",
        "_UID" : "108",
        "__CURSOR" : "s=aed145c9a2e34842977fe930812a9ac8;i=83633;b=f74ea6b780ab457aa78b2588f84dccef;m=63dc9f7b5a;t=61e61c704384b;x=83318b237586f0ce",
        "__MONOTONIC_TIMESTAMP" : "428903201626",
        "__REALTIME_TIMESTAMP" : "1722255159867467"
}

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully built and tested this version. The journal now contains "ICINGA_NOTIFICATIONS_… fields.

@julianbrost julianbrost merged commit b325da1 into main Jul 29, 2024
26 checks passed
@julianbrost julianbrost deleted the dependabot/go_modules/github.com/icinga/icinga-go-library-0.3.1 branch July 29, 2024 12:26
@julianbrost julianbrost mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging to systemd-journald misses detail fields
2 participants