Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utils.IterateOrderedMap() as intended, via for:=range (require Go 1.23) #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use utils.IterateOrderedMap() as intended, via for:=range (require Go 1.23) #276

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added the go Pull requests that update Go code label Aug 22, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 22, 2024
@Al2Klimov Al2Klimov requested a review from oxzi August 22, 2024 08:59
@Al2Klimov Al2Klimov force-pushed the IterateOrderedMap-1.23 branch from ef004d8 to 722b6ae Compare August 22, 2024 09:03
oxzi
oxzi reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future!

While this looks good at a first glance, I would like to wait some weeks before bumping the Go version. Allowing each of us to get to the latest Go version in their pace, before hitting build failures.

@Al2Klimov
Copy link
Member Author

Dev's platforms w/ Go 1.23

@oxzi
Copy link
Member

oxzi commented Aug 26, 2024

Thanks for the roadmap. Just for your information, Go 1.23 is already available in the nixpkgs, just not under the go package name, as this would result a massive rebuild. The go package will be bumped for the next staging thing, iirc.

https://search.nixos.org/packages?channel=unstable&show=go_1_23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @oxzi