Initial Icinga Notifications Support #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all (transitive) Go dependencies - Update GitHub Actions - gofmt code, as also tested by GitHub Actions
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Dec 20, 2023
Heavily inspired by the already existing integration tests from Icinga DB, the icinga-testing project was extended to support Icinga Notifications[0]. Based on those changes, an initial integration test was implemented for Icinga Notifications, currently just launching PostgreSQL, Icinga 2, and Icinga Notifications, waiting for Icinga Notifications to scan the available channels and write them into the database. [0] Icinga/icinga-testing#25
oxzi
force-pushed
the
icinga-notifications-init
branch
from
686d5c9 to
8f5c4c4
Compare
|
Marked as draft as there might be still changes. Should be merged together - but before - Icinga/icinga-notifications#144. |
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Jan 2, 2024
Heavily inspired by the already existing integration tests from Icinga DB, the icinga-testing project was extended to support Icinga Notifications[0]. Based on those changes, an initial integration test was implemented for Icinga Notifications, currently just launching PostgreSQL, Icinga 2, and Icinga Notifications, waiting for Icinga Notifications to scan the available channels and write them into the database. [0] Icinga/icinga-testing#25
oxzi
force-pushed
the
icinga-notifications-init
branch
from
8f5c4c4 to
04e31ac
Compare
|
Changed logic to use icinga-notification's Dockerfile. |
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Jan 3, 2024
Heavily inspired by the already existing integration tests from Icinga DB, the icinga-testing project was extended to support Icinga Notifications[0]. Based on those changes, an initial integration test was implemented for Icinga Notifications, currently just launching PostgreSQL, Icinga 2, and Icinga Notifications, waiting for Icinga Notifications to scan the available channels and write them into the database. [0] Icinga/icinga-testing#25
Inspired by the existing code for the Icinga DB, support for Icinga Notifications was added. Thus, there might be some level of code duplication between those two. The custom Icinga 2 configuration was sourced from the Icinga Notifications repository, but edited to not being parsed as a faulty Go template.
oxzi
force-pushed
the
icinga-notifications-init
branch
from
04e31ac to
091308c
Compare
Would you mind making a separate PR for that? That should be faster to merge and then keeps this PR smaller and focused on topic.
This project missed some access rule for a team, should be fixed. |
#27 as I am now using this repository as the git remote. |
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Jan 9, 2024
Heavily inspired by the already existing integration tests from Icinga DB, the icinga-testing project was extended to support Icinga Notifications[0]. Based on those changes, an initial integration test was implemented for Icinga Notifications, currently just launching PostgreSQL, Icinga 2, and Icinga Notifications, waiting for Icinga Notifications to scan the available channels and write them into the database. [0] Icinga/icinga-testing#25
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Jan 12, 2024
Heavily inspired by the already existing integration tests from Icinga DB, the icinga-testing project was extended to support Icinga Notifications[0]. Based on those changes, an initial integration test was implemented for Icinga Notifications, currently just launching PostgreSQL, Icinga 2, and Icinga Notifications, waiting for Icinga Notifications to scan the available channels and write them into the database. [0] Icinga/icinga-testing#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Icinga Notifications
Inspired by the existing code for the Icinga DB, support for Icinga
Notifications was added. Thus, there might be some level of code
duplication between those two.
The custom Icinga 2 configuration was sourced from the Icinga
Notifications repository, but edited to not being parsed as a faulty Go
template.
Update dependencies and gofmt code
I forked the repository and created the PR from a fork in my user's namespace as I don't have permissions to push to this repo.