Icinga2Client#Do(): call parent method, re-try on HTTP 503 300 times #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestsBefore: https://github.com/Al2Klimov/icingadb/actions/runs/8234573747 TODO
|
julianbrost
requested changes
Mar 12, 2024
julianbrost
reviewed
Mar 12, 2024
oxzi
reviewed
Mar 13, 2024
|
|
||
| for attempt := 1; ; attempt++ { | ||
| response, err := c.Client.Do(req) | ||
| if err == nil && response.StatusCode == http.StatusServiceUnavailable && req.GetBody != nil && attempt < 300 { |
There was a problem hiding this comment.
attempt < 300 with attempt starting at 1 results in performing c.Client.Do() 300 times, not re-trying 300 times.
There was a problem hiding this comment.
The number of attempts isn't even the most relevant part here. It retries for roughly 5 minutes, which should be plenty for our tests.
julianbrost
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an Icinga 2 reload, there are phases where the API can't perform config changes and replies with an HTTP 503 error instead (see Icinga/icinga2#9445 for example) which means that the client should retry the operation at a later time. The PR retries such errors for approximately 5 minutes (plus response times).
refs Icinga/icingadb#685