Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test VerifyCertificate() #10329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test VerifyCertificate() #10329

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Jan 28, 2025 •
edited
Loading

These unit tests (work on my machine and) prove that VerifyCertificate() is secure (across OS).

@Al2Klimov Al2Klimov added the core/quality Improve code, libraries, algorithms, inline docs label Jan 28, 2025
@Al2Klimov Al2Klimov requested a review from lippserd January 28, 2025 11:58
@cla-bot cla-bot bot added the cla/signed label Jan 28, 2025
@Al2Klimov Al2Klimov force-pushed the Test-VerifyCertificate branch from e74e5f9 to 8fe67fc Compare January 28, 2025 12:01
@Al2Klimov Al2Klimov marked this pull request as draft January 28, 2025 14:07
@Al2Klimov Al2Klimov removed the request for review from lippserd January 28, 2025 14:07
@Al2Klimov Al2Klimov self-assigned this Jan 28, 2025
Al2Klimov
Al2Klimov commented Jan 28, 2025
View reviewed changes
test/base-tlsutility.cpp Outdated Show resolved Hide resolved
oxzi
oxzi reviewed Jan 29, 2025
View reviewed changes
test/base-tlsutility.cpp Outdated Show resolved Hide resolved
Al2Klimov
Al2Klimov commented Jan 29, 2025
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
@Al2Klimov Al2Klimov force-pushed the Test-VerifyCertificate branch from f31bf94 to 298c0d8 Compare January 29, 2025 12:08
@Al2Klimov Al2Klimov marked this pull request as ready for review January 29, 2025 12:09
@Al2Klimov Al2Klimov force-pushed the Test-VerifyCertificate branch 3 times, most recently from e98084c to 715046b Compare January 29, 2025 14:26
@Al2Klimov Al2Klimov force-pushed the Test-VerifyCertificate branch from 715046b to 8f82b98 Compare February 3, 2025 14:31
@Al2Klimov Al2Klimov removed their assignment Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla/signed core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @oxzi