Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA AUTHORS check: handle PRs from forks #9976

Merged
merged 1 commit into from
Jan 22, 2024
Merged

GHA AUTHORS check: handle PRs from forks #9976

merged 1 commit into from
Jan 22, 2024

Conversation

Al2Klimov
Copy link
Member

where the ref names differ compared to own PRs. Instead refer to the base branch and the head branch via generic HEAD^ where HEAD is a merge commit.

@Al2Klimov Al2Klimov added the area/ci CI/CD label Jan 18, 2024
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Jan 18, 2024
@Al2Klimov Al2Klimov self-assigned this Jan 18, 2024
@cla-bot cla-bot bot added the cla/signed label Jan 18, 2024
@cla-bot cla-bot bot removed the cla/signed label Jan 18, 2024
@Al2Klimov
GHA AUTHORS check: handle PRs from forks
82e9c71 
where the ref names differ compared to own PRs. Instead refer to the base branch and the head branch via generic HEAD^<parent number> where HEAD is a merge commit.
@Icinga Icinga deleted a comment from cla-bot bot Jan 18, 2024
@Icinga Icinga deleted a comment from cla-bot bot Jan 18, 2024
@Al2Klimov Al2Klimov requested a review from julianbrost January 18, 2024 16:23
@Al2Klimov
Copy link
Member Author

Source: https://stackoverflow.com/a/9059633

@Al2Klimov
Copy link
Member Author

This PR blocks every new or updated external PR, including:

julianbrost
julianbrost reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do the trick, please remove the second commit.

@cla-bot cla-bot bot added the cla/signed label Jan 22, 2024
@Al2Klimov Al2Klimov removed their assignment Jan 22, 2024
@Al2Klimov Al2Klimov requested a review from julianbrost January 22, 2024 13:31
@julianbrost julianbrost enabled auto-merge January 22, 2024 13:33
@julianbrost julianbrost merged commit 01a6c4c into Icinga:master Jan 22, 2024
25 checks passed
@Al2Klimov Al2Klimov deleted the Al2Klimov-patch-42 branch March 11, 2024 11:46
@Al2Klimov Al2Klimov added the consider backporting Should be considered for inclusion in a bugfix release label May 14, 2024
This was referenced Jun 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/ci CI/CD cla/signed consider backporting Should be considered for inclusion in a bugfix release
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost