(Host|Service)Controller: Fix tab activation

- Set the outer tab as active. Previously, the inner tab was activated in the setTitleTab method, but the outer tab does not know about the state of inner tabs. So whenever sendMultipartUpdate() -> getActiveTab() was called, the retured value was always null.
Icinga · Dec 18, 2024 · 2762f6f · 2762f6f
1 parent 3f96fd3
commit 2762f6f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/application/controllers/HostController.php b/application/controllers/HostController.php
@@ -478,9 +478,7 @@ protected function setTitleTab(string $name)
         $tab = $this->createTabs()->get($name);
 
         if ($tab !== null) {
-            $tab->setActive();
-
-            $this->setTitle($tab->getLabel());
+            $this->getTabs()->activate($name);
         }
     }
 

diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
@@ -450,9 +450,7 @@ protected function setTitleTab(string $name)
         $tab = $this->createTabs()->get($name);
 
         if ($tab !== null) {
-            $tab->setActive();
-
-            $this->setTitle($tab->getLabel());
+            $this->getTabs()->activate($name);
         }
     }