Fix failed to resolve reversed host/service -> comment relations (#…

…858) fixes #827
Icinga · Sep 6, 2023 · cacc770 · cacc770
2 parents c626bc1 + b17c306
commit cacc770
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 9 deletions.
diff --git a/library/Icingadb/Model/Comment.php b/library/Icingadb/Model/Comment.php
@@ -108,13 +108,7 @@ public function createRelations(Relations $relations)
     {
         $relations->belongsTo('environment', Environment::class);
         $relations->belongsTo('host', Host::class)->setJoinType('LEFT');
-        $relations->belongsTo('host_state', HostState::class)
-            ->setForeignKey('last_comment_id')
-            ->setCandidateKey('id');
         $relations->belongsTo('service', Service::class)->setJoinType('LEFT');
-        $relations->belongsTo('service_state', ServiceState::class)
-            ->setForeignKey('last_comment_id')
-            ->setCandidateKey('id');
         $relations->belongsTo('zone', Zone::class);
     }
 }
diff --git a/library/Icingadb/Model/HostState.php b/library/Icingadb/Model/HostState.php
@@ -61,7 +61,7 @@ public function createRelations(Relations $relations)
     {
         $relations->belongsTo('environment', Environment::class);
         $relations->belongsTo('host', Host::class);
-        $relations->hasOne('last_comment', Comment::class)
+        $relations->hasOne('last_comment', LastHostComment::class)
             ->setCandidateKey('last_comment_id')
             ->setForeignKey('id')
             ->setJoinType('LEFT');

diff --git a/library/Icingadb/Model/LastHostComment.php b/library/Icingadb/Model/LastHostComment.php
@@ -0,0 +1,19 @@
+<?php
+
+/* Icinga DB Web | (c) 2023 Icinga GmbH | GPLv2 */
+
+namespace Icinga\Module\Icingadb\Model;
+
+use ipl\Orm\Relations;
+
+class LastHostComment extends Comment
+{
+    public function createRelations(Relations $relations): void
+    {
+        $relations->belongsTo('environment', Environment::class);
+        $relations->belongsTo('zone', Zone::class);
+        $relations->belongsTo('state', HostState::class)
+            ->setForeignKey('last_comment_id')
+            ->setCandidateKey('id');
+    }
+}
diff --git a/library/Icingadb/Model/LastServiceComment.php b/library/Icingadb/Model/LastServiceComment.php
@@ -0,0 +1,19 @@
+<?php
+
+/* Icinga DB Web | (c) 2023 Icinga GmbH | GPLv2 */
+
+namespace Icinga\Module\Icingadb\Model;
+
+use ipl\Orm\Relations;
+
+class LastServiceComment extends Comment
+{
+    public function createRelations(Relations $relations): void
+    {
+        $relations->belongsTo('environment', Environment::class);
+        $relations->belongsTo('zone', Zone::class);
+        $relations->belongsTo('state', ServiceState::class)
+            ->setForeignKey('last_comment_id')
+            ->setCandidateKey('id');
+    }
+}
diff --git a/library/Icingadb/Model/ServiceState.php b/library/Icingadb/Model/ServiceState.php
@@ -58,7 +58,7 @@ public function createRelations(Relations $relations)
     {
         $relations->belongsTo('environment', Environment::class);
         $relations->belongsTo('service', Service::class);
-        $relations->hasOne('last_comment', Comment::class)
+        $relations->hasOne('last_comment', LastServiceComment::class)
             ->setCandidateKey('last_comment_id')
             ->setForeignKey('id')
             ->setJoinType('LEFT');

diff --git a/library/Icingadb/Web/Control/SearchBar/ObjectSuggestions.php b/library/Icingadb/Web/Control/SearchBar/ObjectSuggestions.php
@@ -387,7 +387,7 @@ protected static function collectRelations(Resolver $resolver, Model $subject, a
             /** @var Relation $relation */
             if (
                 empty($path) || (
-                    $name === 'state'
+                    ($name === 'state' && $path[count($path) - 1] !== 'last_comment')
                     || $name === 'last_comment'
                     || $name === 'notificationcommand' && $path[0] === 'notification'
                 )