Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show affected objects in the object detail for failed dependencies #1072

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Show affected objects in the object detail for failed dependencies #1072

merged 1 commit into from
Oct 31, 2024

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Oct 7, 2024 •
edited
Loading

resolves #1064

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 7, 2024
@raviks789 raviks789 force-pushed the root-problem-list branch 8 times, most recently from 243c129 to 8782937 Compare October 11, 2024 11:06
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch 2 times, most recently from 799516b to efa1722 Compare October 14, 2024 08:04
@raviks789 raviks789 force-pushed the root-problem-list branch 3 times, most recently from d65f68d to 4a34a1c Compare October 14, 2024 13:54
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from efa1722 to c7040a4 Compare October 14, 2024 14:39
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from c7040a4 to 0b34213 Compare October 15, 2024 08:34
@raviks789 raviks789 force-pushed the root-problem-list branch 2 times, most recently from 489d077 to 6b52b63 Compare October 15, 2024 11:28
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from 0b34213 to 88e2ca2 Compare October 16, 2024 08:25
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch 2 times, most recently from ec07352 to 67ab3aa Compare October 17, 2024 12:55
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from 67ab3aa to 3240a6a Compare October 17, 2024 13:50
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from 3240a6a to f5e2363 Compare October 18, 2024 13:34
sukhwinder33445
sukhwinder33445 previously requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is not limited to 5 items, as required.

library/Icingadb/Widget/Detail/ObjectDetail.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/Detail/ObjectDetail.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/Detail/ObjectDetail.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from f5e2363 to 500d8f5 Compare October 23, 2024 13:53
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch 2 times, most recently from 61a919a to e4e1d98 Compare October 24, 2024 12:15
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch 3 times, most recently from bffba28 to c42b4c9 Compare October 24, 2024 12:21
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from c42b4c9 to f2bfee4 Compare October 25, 2024 10:56
@raviks789 raviks789 force-pushed the root-problem-list branch 7 times, most recently from f2ffe25 to 4be5a02 Compare October 30, 2024 16:00
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from f2bfee4 to 676210f Compare October 30, 2024 16:19
@nilmerg nilmerg marked this pull request as ready for review October 31, 2024 07:21
Base automatically changed from root-problem-list to dependencies October 31, 2024 11:07
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from 676210f to 86b2ceb Compare October 31, 2024 11:36
nilmerg
nilmerg approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nilmerg nilmerg added the enhancement New feature or improvement label Oct 31, 2024
@raviks789 raviks789 force-pushed the detail-view/affected-children-list branch from 86b2ceb to 4f47f6e Compare October 31, 2024 12:54
@nilmerg nilmerg merged commit e8f1892 into dependencies Oct 31, 2024
22 checks passed
@nilmerg nilmerg deleted the detail-view/affected-children-list branch October 31, 2024 14:03
@nilmerg nilmerg linked an issue Oct 31, 2024 that may be closed by this pull request
Show a list of affected children in the host/service detail if it has a problem and is part of a dependency #1064
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 left review comments

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a list of affected children in the host/service detail if it has a problem and is part of a dependency
3 participants
@raviks789 @nilmerg @sukhwinder33445