Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: Update models to reflect latest schema updates #1113

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Dec 17, 2024

No description provided.

@nilmerg nilmerg requested a review from raviks789 December 17, 2024 13:51
@nilmerg nilmerg self-assigned this Dec 17, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 17, 2024
@nilmerg nilmerg changed the base branch from use-singleton-for-db-and-redis-connections to dependencies December 17, 2024 13:51
@nilmerg nilmerg force-pushed the support-icingadb-schema-v6 branch from 4f72538 to 48d822f Compare December 17, 2024 13:52
Copy link
Contributor

@raviks789 raviks789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_reachable column is missing in RedundancyGroupState model.

Comment on lines 43 to 49
$behaviors->add(new BoolCast([
'failed'
]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$behaviors->add(new BoolCast([
'failed'
]));
$behaviors->add(new Binary([
'id'
]));
$behaviors->add(new BoolCast([
'failed'
]));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nilmerg nilmerg force-pushed the support-icingadb-schema-v6 branch from 48d822f to 804be8b Compare December 17, 2024 16:33
@nilmerg
Copy link
Member Author

nilmerg commented Dec 17, 2024

is_reachable column is missing in RedundancyGroupState model.

Will be added by #1073

Copy link
Contributor

@raviks789 raviks789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilmerg nilmerg merged commit 945eb5f into dependencies Dec 17, 2024
22 checks passed
@nilmerg nilmerg deleted the support-icingadb-schema-v6 branch December 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants