IcingaDbWizard: Fix requirements #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix-setup-wizard-requirements
branch
from
abdbc42 to
47a1c2f
Compare
nilmerg
requested changes
Sep 5, 2023
sukhwinder33445
force-pushed
the
fix-setup-wizard-requirements
branch
from
47a1c2f to
870b641
Compare
nilmerg
approved these changes
Sep 8, 2023
- The php version requirement has been removed as it is already defined in icingaweb.
- Setting `autocomplete` to `off` does not work, but `new-password` does.
sukhwinder33445
force-pushed
the
fix-setup-wizard-requirements
branch
from
870b641 to
b2a512d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Icinga/icingaweb2#5094
TODOs
icinga-php-thirdpartyin module.info and module doc does not match.