Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action-list.js: Don't add footer for list in .controls #867

Merged
merged 3 commits into from
Sep 12, 2023
Merged

action-list.js: Don't add footer for list in .controls #867

merged 3 commits into from
Sep 12, 2023

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Sep 12, 2023 •
edited
Loading

fixes #866

@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Sep 12, 2023
@sukhwinder33445 sukhwinder33445 self-assigned this Sep 12, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 12, 2023
@sukhwinder33445 sukhwinder33445 changed the title action-list.js: Don't add footer for list in .controls > .action-list action-list.js: Don't add footer for list in .controls Sep 12, 2023
@nilmerg
Copy link
Member

nilmerg commented Sep 12, 2023

Is this an oversight and lists not in the content weren't navigable anyway? Or may now some lists not navigable anymore?

@sukhwinder33445
Copy link
Contributor Author

As discussed offline, only primary lists are navigable. We will stick to this behaviour for now.

@nilmerg nilmerg linked an issue Sep 12, 2023 that may be closed by this pull request
Do not show multiselect note in "continue with filter" detail view #866
Closed
nilmerg
nilmerg requested changes Sep 12, 2023
View reviewed changes
library/Icingadb/Common/DetailActions.php Outdated Show resolved Hide resolved
public/js/action-list.js Outdated Show resolved Hide resolved
@nilmerg
Copy link
Member

nilmerg commented Sep 12, 2023

@cla-bot check

1 similar comment
@nilmerg
Copy link
Member

nilmerg commented Sep 12, 2023

@cla-bot check

@nilmerg nilmerg force-pushed the fix/detail-view-footer branch from a2da532 to 5c30e53 Compare September 12, 2023 11:57
@nilmerg nilmerg merged commit 84eeeaa into master Sep 12, 2023
12 checks passed
@nilmerg nilmerg deleted the fix/detail-view-footer branch September 12, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show multiselect note in "continue with filter" detail view
2 participants
@sukhwinder33445 @nilmerg