Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that some macros break the host detail #904

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Oct 9, 2023

fixes #900

@nilmerg nilmerg added bug Something isn't working area/view Affects an entire view labels Oct 9, 2023
@nilmerg nilmerg added this to the 1.1.1 milestone Oct 9, 2023
@nilmerg nilmerg self-assigned this Oct 9, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 9, 2023
@nilmerg nilmerg requested a review from yhabteab October 9, 2023 12:51
yhabteab
yhabteab previously approved these changes Oct 9, 2023
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are not only some macros but every single host macros🤦.

@yhabteab
Copy link
Member

yhabteab commented Oct 9, 2023

One more thing: If monitoring is not there the tests fails fatal like this (at least locally):

Error : Class "Icinga\Module\Monitoring\Object\Host" not found
 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Compat/CompatHost.php:9
 /icingaweb2/library/Icinga/Application/ClassLoader.php:275
 /usr/share/icingaweb2-modules/icingadb/test/php/library/Icingadb/Common/MacrosTest.php:44
 

Error : Class "Icinga\Module\Monitoring\Object\Service" not found
 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Compat/CompatService.php:9
 /icingaweb2/library/Icinga/Application/ClassLoader.php:275
 /usr/share/icingaweb2-modules/icingadb/test/php/library/Icingadb/Common/MacrosTest.php:110

The if conditions in the tests don't behave as you might expect to.

@nilmerg nilmerg force-pushed the fix/macros-break-host-detail-900 branch from eb8d27f to 946f65c Compare October 10, 2023 08:08
@nilmerg nilmerg requested a review from yhabteab October 10, 2023 08:08
@nilmerg nilmerg merged commit 4ff4443 into main Oct 13, 2023
12 checks passed
@nilmerg nilmerg deleted the fix/macros-break-host-detail-900 branch October 13, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/view Affects an entire view bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action macros break object details
2 participants