Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension required by Icinga Notifications #578

Closed
wants to merge 1 commit into from
Closed

Add extension required by Icinga Notifications #578

wants to merge 1 commit into from

Conversation

yhabteab
Copy link
Member

This allows the user to provide the constraint name dynamically, e.g for tables that doesn't have a PK but a UNIQUE KEY constraint.

@cla-bot cla-bot bot added the cla/signed label Apr 18, 2023
@julianbrost julianbrost marked this pull request as draft April 21, 2023 09:05
@oxzi
Copy link
Member

oxzi commented Apr 18, 2024

As I just needed this today: Happy Birthday little #578 🍰

@yhabteab @oxzi
Add contracts.Constrainter & use it in db#Upsert/InsertIgnore stmt
1e3dea1 
This allows the user to provide the constraint name dynamically, e.g
for tables that doesn't have a PK but a `UNIQUE KEY` constraint.
@oxzi
Copy link
Member

oxzi commented Apr 18, 2024

I just took over this PR as I needed a change in Icinga DB (or the future Go library) for Icinga/icinga-notifications#61. Next to rebasing this branch, I added one commit introducing a more precise time type, representing nanoseconds.

@oxzi oxzi changed the title Add some extension required by noma Add extension required by Icinga Notifications Apr 18, 2024
@julianbrost
Copy link
Contributor

I added one commit introducing a more precise time type, representing nanoseconds.

But why for what?

@oxzi
Copy link
Member

oxzi commented Apr 18, 2024

I added one commit introducing a more precise time type, representing nanoseconds.

But why for what?

Icinga/icinga-notifications#61

@oxzi
Copy link
Member

oxzi commented Apr 19, 2024

After talking with @julianbrost about Icinga/icinga-notifications#61, it turns out that I haven't needed a nanoseconds type. Hooray!

This PR and its branch now contains @yhabteab's change, just rebased against the current main branch.

@oxzi oxzi mentioned this pull request Apr 19, 2024
Closed
oxzi added a commit to Icinga/icinga-notifications that referenced this pull request Apr 30, 2024
@oxzi
Bump github.com/icinga/icingadb dependency
1bd95b5 
The changed icingadb dependencies contains the latest state of the noma
branch[0] with an additional fix for utils.FromUnixMilli[1,2].

[0]: Icinga/icingadb#578
[1]: Icinga/icingadb#753
[2]: Icinga/icingadb@066abea
@oxzi oxzi mentioned this pull request Apr 30, 2024
Merged
oxzi added a commit to Icinga/icinga-notifications that referenced this pull request May 27, 2024
@oxzi
Bump github.com/icinga/icingadb dependency
f00ae66 
The changed icingadb dependencies contains the latest state of the noma
branch[0] with an additional fix for utils.FromUnixMilli[1,2].

[0]: Icinga/icingadb#578
[1]: Icinga/icingadb#753
[2]: Icinga/icingadb@066abea
@yhabteab
Copy link
Member Author

No longer required, since https://github.com/Icinga/icinga-go-library.

@yhabteab yhabteab closed this Jul 30, 2024
@yhabteab yhabteab deleted the noma branch July 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhabteab @oxzi @julianbrost