Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-redis to v9 #715

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Upgrade go-redis to v9 #715

merged 1 commit into from
Mar 25, 2024

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Mar 22, 2024 •
edited by oxzi
Loading

Closes #708.

@cla-bot cla-bot bot added the cla/signed label Mar 22, 2024
@oxzi oxzi self-assigned this Mar 22, 2024
@oxzi oxzi mentioned this pull request Mar 22, 2024
Merged
@oxzi
Copy link
Member

oxzi commented Mar 22, 2024

I pushed a commit referencing this Icinga/icinga-testing#30 icinga-testing version.

After that PR got merged, this one needs to update its icinga-testing dependency again, afterwards it should be fine to be merged.

@oxzi oxzi added this to the 1.1.2 milestone Mar 22, 2024
@lippserd @oxzi
Upgrade go-redis to v9
e31b101 
Co-Authored-By: Alvar Penning <[email protected]>
@oxzi oxzi assigned oxzi and lippserd and unassigned oxzi Mar 22, 2024
@oxzi oxzi marked this pull request as ready for review March 22, 2024 14:50
@lippserd lippserd removed their assignment Mar 24, 2024
@oxzi oxzi requested a review from julianbrost March 25, 2024 09:17
@julianbrost
Copy link
Contributor

The changelog for v9 only mentions that pipelines are no longer thread-safe. The two places where we use pipelines (overdue sync, runtime updates) don't do any parallelization where they use these pipelines, so that should be just fine.

julianbrost
julianbrost approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, I gave it a quick run locally, seems to work just fine.

@julianbrost julianbrost merged commit 194028a into main Mar 25, 2024
31 checks passed
@julianbrost julianbrost deleted the go-redis-v9 branch March 25, 2024 10:02
@oxzi oxzi added the dependencies Pull requests that update a dependency file label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
cla/signed dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Update to github.com/redis/go-redis/v9
3 participants
@lippserd @oxzi @julianbrost