Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry: distinguish non-retryable errors from timeouts #719

Closed
wants to merge 1 commit into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 26, 2024

The WithBackoff function returns a wrapped error with the message "can't retry" both for errors marked as non-retryable by IsRetryable as well as when the context is done. The latter might happen when a positive settings.Timeout is specified, as this results in a wrapped context with a timeout.

This behavior resulted in me debugging the IsRetryable function, when just the Timeout has exceeded. To save others from having this experience, I have adapted the messages.

The WithBackoff function returns a wrapped error with the message "can't
retry" both for errors marked as non-retryable by IsRetryable as well as
when the context is done. The latter might happen when a positive
settings.Timeout is specified, as this results in a wrapped context with
a timeout.

This behavior resulted in me debugging the IsRetryable function, when
just the Timeout has exceeded. To save others from having this
experience, I have adapted the messages.
@cla-bot cla-bot bot added the cla/signed label Mar 26, 2024
@oxzi
Copy link
Member Author

oxzi commented Apr 3, 2024

#698 addresses the same issue.

@oxzi oxzi closed this Apr 3, 2024
@oxzi oxzi deleted the retry-cant-retry-reason branch April 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant