Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version 1.2.0 #734

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Release Version 1.2.0 #734

merged 2 commits into from
Apr 11, 2024

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 9, 2024

Part of #707. Should be merged last before drafting the release.

@oxzi oxzi added this to the 1.1.2 milestone Apr 9, 2024
@oxzi oxzi requested review from julianbrost and lippserd April 9, 2024 15:06
@cla-bot cla-bot bot added the cla/signed label Apr 9, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@oxzi oxzi force-pushed the i707-release-v1.1.2 branch from b37f18a to d372cc9 Compare April 10, 2024 09:56
@oxzi oxzi requested a review from julianbrost April 10, 2024 09:57
@oxzi oxzi force-pushed the i707-release-v1.1.2 branch 6 times, most recently from f008b34 to ccd2692 Compare April 10, 2024 12:30
@oxzi oxzi changed the title Release Version 1.1.2 Release Version 1.2.0 Apr 10, 2024
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, I'm waiting for everything else to be done for a final approval though.

CHANGELOG.md Outdated Show resolved Hide resolved
@oxzi oxzi force-pushed the i707-release-v1.1.2 branch from ccd2692 to 37ed5af Compare April 11, 2024 07:54
@oxzi oxzi requested a review from julianbrost April 11, 2024 07:57
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has to be adapted to the short notice PRs. At least #739 should be mentioned as EPIPE is mentioned explicitly already. (There might be more noteworthy ones, I haven't checked all so far.)

@oxzi oxzi force-pushed the i707-release-v1.1.2 branch from 37ed5af to 018d898 Compare April 11, 2024 11:06
@oxzi
Copy link
Member Author

oxzi commented Apr 11, 2024

@julianbrost: I rebased this PR's branch onto main. Afterwards, I reworded the CHANGELOG to group similar changes (especially everything retry-related) and include the latest additions.

@oxzi oxzi requested review from julianbrost and yhabteab April 11, 2024 11:07
@oxzi oxzi force-pushed the i707-release-v1.1.2 branch from 018d898 to 8206c40 Compare April 11, 2024 11:14
@oxzi oxzi force-pushed the i707-release-v1.1.2 branch from 8206c40 to f0b7aa2 Compare April 11, 2024 11:23
@julianbrost
Copy link
Contributor

Afterwards, I reworded the CHANGELOG to group similar changes (especially everything retry-related) and include the latest additions.

Looks like you have lost #692 in the process.

@oxzi
Copy link
Member Author

oxzi commented Apr 11, 2024

Looks like you have lost #692 in the process.

This was intentional, as, on second thought, I found this change to be irrelevant for a CHANGELOG entry.

@oxzi oxzi merged commit a0a65af into main Apr 11, 2024
31 checks passed
@oxzi oxzi deleted the i707-release-v1.1.2 branch April 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants