Unify notation of n * time.Duration
#738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
reviewed
Apr 11, 2024
There was a problem hiding this comment.
The changes are looking fine. However, I found one other occurrence with egrep -r 'time\..*[0-9]+' .:
icingadb/pkg/icingadb/driver.go
Line 58 in 8ef32e1
Yes, but #698 changes that line anyway. |
|
As #698 got merged, this can be rebased and also merged before the release. |
lippserd
force-pushed
the
unify-time-duration-notation
branch
from
8ef32e1 to
5029e32
Compare
oxzi
approved these changes
Apr 11, 2024
yhabteab
approved these changes
Apr 11, 2024
julianbrost
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #698 because of #738 (comment).