Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/icingadb-migrate: replace magic number 20 with sha1.Size #769

Merged
merged 1 commit into from
Jul 9, 2024
Merged

cmd/icingadb-migrate: replace magic number 20 with sha1.Size #769

merged 1 commit into from
Jul 9, 2024

Conversation

Al2Klimov
Copy link
Member

Test

bad env ID: must be 20 bytes long, has 21 bytes

👍

@Al2Klimov Al2Klimov added the bug Something isn't working label Jul 9, 2024
@Al2Klimov Al2Klimov requested a review from oxzi July 9, 2024 12:59
@cla-bot cla-bot bot added the cla/signed label Jul 9, 2024
@Al2Klimov
Copy link
Member Author

I'd let GH rebase-and-merge btw.

@oxzi oxzi merged commit b6839ce into icingadb-migrate-check-env-id-length Jul 9, 2024
31 checks passed
@oxzi oxzi deleted the icingadb-migrate-check-env-id-length-sha1 branch July 9, 2024 13:30
@oxzi
Copy link
Member

oxzi commented Jul 9, 2024

FTR: Pull Request went against #768, not the main branch.

@Al2Klimov Al2Klimov mentioned this pull request Jul 9, 2024
Merged
@oxzi oxzi added this to the 1.2.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @oxzi