Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return vpc_id if it is set #5

Closed
mbassett opened this issue Oct 31, 2016 · 3 comments · Fixed by #30
Closed

return vpc_id if it is set #5

mbassett opened this issue Oct 31, 2016 · 3 comments · Fixed by #30

Comments

@mbassett
Copy link

I do not see any way of retrieving the vpc_id from EC2 instance data source

We are migrating all of our services into VPC's and I'd like to be able to use the vpc_id as the zone

@mbassett
Copy link
Author

mbassett commented Oct 31, 2016

Added to Aws/ProvidedHook/Director/ImportSource.php is that the only place needed?

@Thomas-Gelf
Copy link
Collaborator

And to the extractAttributes calls in Aws/AwsClient::extractAttributes, it's pretty easy. First array is for required option, import will fail when any is missing - second array is for optional ones, those that do not exist on every instance. Left key is the property name as it will be imported, right column is the AWS property name.

In case it works for you it would be cool if you could send me a pull request!

@mbassett
Copy link
Author

mbassett commented Feb 2, 2017

it's weird, these values are available inside the sync job, but if you look at the import results, none of the variables have any data. instead all the data is contained inside tags field.

this means I can't use any of the tag data from filters

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants