-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new metadata, importsource tweak #12
Conversation
Current extract tags function does not allow for the usage of the tags in the import filter. This small update creates variables in the expected format tags.{attr} so you can use that in your sync filters.
This reverts commit 89da63b.
I thought this fixed it for sync filters, but it seems to have only fixed the preview display tab. :'( |
So far as I can tell... filters that work: filters that don't work: I even tried adding new fields name_tag and asg_group_tag and those also did not work in filters (and yes i added them to the ImportSource.php also )
|
@Thomas-Gelf Can you tell me why this isn't working? I see values in the import source preview page, but they do not seem to be applying in the sync role. specifically 283da03 and the other minor commits around it? I see the value for disabled = 1 for hosts that are not in running state, but the sync rule does not disable them. |
@dnsmichi @Thomas-Gelf Can this be merged please? |
@walterheck: sure! I'll check whether this is still necessary... $result->tags->{$t['Key']} = $t['Value'];
+ // so we can use these tags in the expected way in import filters via tags.attribute
+ $result->{'tags.'.$t['Key']} = $t['Value']; ...as in the meantime there should have been a related change in Director itself. The rest looks good! Sorry for the delay @mbassett, this got completely forgotten. Cheers, |
Since #18 has been merged, I close this as duplicate. Thanks for your efforts though! |
Add support for new information from ec2 instance metadata
Tweak importsource to also set tags.{key} variables for use in sync filters.
Fixes #2 and #5