Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RDS support #24

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Add RDS support #24

merged 1 commit into from
Sep 20, 2018

Conversation

mzhaase
Copy link
Contributor

@mzhaase mzhaase commented Sep 20, 2018

Supports importing RDS instances, with properties:

  • name
  • engine
  • engine version
  • security groups
  • fqdn
  • port
  • tags

@Thomas-Gelf Thomas-Gelf self-requested a review September 20, 2018 15:11
Thomas-Gelf
Thomas-Gelf approved these changes Sep 20, 2018
View reviewed changes
Copy link
Collaborator

@Thomas-Gelf Thomas-Gelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I didn't test it with any AWS account right now, but the code looks good to me!

@Thomas-Gelf Thomas-Gelf merged commit 327894c into Icinga:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Gelf Thomas-Gelf Thomas-Gelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzhaase @Thomas-Gelf