Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IAM role credentials default #31

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Make IAM role credentials default #31

merged 2 commits into from
Aug 13, 2019

Conversation

mxhash
Copy link
Member

@mxhash mxhash commented Aug 13, 2019

fixes #20

@mxhash mxhash requested a review from N-o-X August 13, 2019 10:15
N-o-X
N-o-X suggested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@N-o-X N-o-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some changes to the documentation, as it's unclear that you even have the option to use IAM.

@mxhash mxhash requested a review from N-o-X August 13, 2019 12:02
N-o-X
N-o-X approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@N-o-X N-o-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@N-o-X N-o-X merged commit 84b904d into master Aug 13, 2019
@N-o-X N-o-X mentioned this pull request Aug 13, 2019
Closed
@N-o-X N-o-X deleted the feature/iam-role-credentials branch August 14, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-X N-o-X N-o-X approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use AWS IAM role credentials
2 participants
@mxhash @N-o-X