Allow to asynchronously generate PDFs #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
do-not-create-own-event-loop
branch
7 times, most recently
from
e676eae to
a1e9bb0
Compare
nilmerg
requested changes
Mar 14, 2024
yhabteab
force-pushed
the
do-not-create-own-event-loop
branch
2 times, most recently
from
5f08ecb to
f2c8ca5
Compare
nilmerg
requested changes
Mar 18, 2024
yhabteab
force-pushed
the
do-not-create-own-event-loop
branch
3 times, most recently
from
5e63f0c to
3be4f74
Compare
nilmerg
requested changes
Mar 19, 2024
nilmerg
previously approved these changes
Mar 22, 2024
sukhwinder33445
force-pushed
the
do-not-create-own-event-loop
branch
from
be6be0a to
8e7ff15
Compare
nilmerg
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
HeadlessChrome::toPdf()always assumes that it controls the event loop instance, i.e.HeadlessChromecreates and starts the event loop manually. This may work for most use cases as they are mostly triggered via Icinga Web, but not if you want to generate PDFs using a daemon. Since our scheduler uses the same global event instance, it is unfavourable to callFactory::create()over again occasionally.refs Icinga/icingaweb2-module-reporting#229