Add property type hint to Report model & update phpstan baseline

Icinga · Sep 12, 2023 · 6ccb9e3 · 6ccb9e3
1 parent 618618d
commit 6ccb9e3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 31 deletions.
diff --git a/library/Reporting/Model/Report.php b/library/Reporting/Model/Report.php
@@ -4,11 +4,23 @@
 
 namespace Icinga\Module\Reporting\Model;
 
+use DateTime;
 use ipl\Orm\Behavior\MillisecondTimestamp;
 use ipl\Orm\Behaviors;
 use ipl\Orm\Model;
 use ipl\Orm\Relations;
 
+/**
+ * A Report database model
+ *
+ * @property int $id Unique identifier of this model
+ * @property int $timeframe_id The timeframe id used by this report
+ * @property int $template_id The template id used by this report
+ * @property string $author The author of this report
+ * @property string $name The name of this report
+ * @property DateTime $ctime The creation time of this report
+ * @property DateTime $mtime Modify time of this report
+ */
 class Report extends Model
 {
     public function getTableName()

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -165,11 +165,6 @@ parameters:
 			count: 1
 			path: application/controllers/ReportsController.php
 
-		-
-			message: "#^Cannot call method format\\(\\) on mixed\\.$#"
-			count: 2
-			path: application/controllers/ReportsController.php
-
 		-
 			message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\ReportsController\\:\\:indexAction\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -190,11 +185,6 @@ parameters:
 			count: 1
 			path: application/controllers/ReportsController.php
 
-		-
-			message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplateController\\:\\:createTabs\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: application/controllers/TemplateController.php
-
 		-
 			message: "#^Method Icinga\\\\Module\\\\Reporting\\\\Controllers\\\\TemplateController\\:\\:editAction\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -215,14 +205,9 @@ parameters:
 			count: 1
 			path: application/controllers/TemplateController.php
 
-		-
-			message: "#^Parameter \\#1 \\$json of function json_decode expects string, mixed given\\.$#"
-			count: 1
-			path: application/controllers/TemplateController.php
-
 		-
 			message: "#^Parameter \\#2 \\$value of static method ipl\\\\Stdlib\\\\Filter\\:\\:equal\\(\\) expects array\\|bool\\|float\\|int\\|string, mixed given\\.$#"
-			count: 2
+			count: 1
 			path: application/controllers/TemplateController.php
 
 		-
@@ -685,21 +670,6 @@ parameters:
 			count: 1
 			path: library/Reporting/Report.php
 
-		-
-			message: "#^Property Icinga\\\\Module\\\\Reporting\\\\Report\\:\\:\\$author \\(string\\) does not accept mixed\\.$#"
-			count: 1
-			path: library/Reporting/Report.php
-
-		-
-			message: "#^Property Icinga\\\\Module\\\\Reporting\\\\Report\\:\\:\\$id \\(int\\) does not accept mixed\\.$#"
-			count: 1
-			path: library/Reporting/Report.php
-
-		-
-			message: "#^Property Icinga\\\\Module\\\\Reporting\\\\Report\\:\\:\\$name \\(string\\) does not accept mixed\\.$#"
-			count: 1
-			path: library/Reporting/Report.php
-
 		-
 			message: "#^Method Icinga\\\\Module\\\\Reporting\\\\ReportData\\:\\:getAverages\\(\\) has no return type specified\\.$#"
 			count: 1