Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-Mail Contacts list for Sending Reports #158

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

E-Mail Contacts list for Sending Reports #158

wants to merge 10 commits into from

Conversation

TAINCER
Copy link

@TAINCER TAINCER commented Nov 8, 2022 •
edited
Loading

Only works when the RadioElement PR from IPL/HTML is applied. Autosubmit functionality is currently not present, changing the Radio Elements has no effect on the page content.

related

depends on

@TAINCER TAINCER self-assigned this Nov 8, 2022
@cla-bot cla-bot bot added the cla/signed label Nov 8, 2022
@TAINCER TAINCER mentioned this pull request Nov 8, 2022
Open
@TAINCER TAINCER requested a review from lippserd November 8, 2022 07:44
@TAINCER TAINCER marked this pull request as draft November 8, 2022 07:45
@TAINCER TAINCER marked this pull request as ready for review December 14, 2022 09:42
yhabteab
yhabteab requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mark all the newly added elements label, description, options label for translation.

library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/SendForm.php Outdated Show resolved Hide resolved
@yhabteab yhabteab added the enhancement New feature or request label Jan 19, 2023
@yhabteab yhabteab added this to the 1.0.0 milestone Jan 19, 2023
@TAINCER TAINCER requested a review from yhabteab January 31, 2023 10:01
@TAINCER TAINCER force-pushed the email-contacts-list branch from 5d67413 to 1a4e85d Compare February 2, 2023 09:09
yhabteab
yhabteab requested changes Feb 2, 2023
View reviewed changes
library/Reporting/Web/Forms/SendForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/SendForm.php Outdated Show resolved Hide resolved
@TAINCER TAINCER force-pushed the email-contacts-list branch from d743983 to e022416 Compare February 2, 2023 09:51
@TAINCER TAINCER requested a review from yhabteab February 2, 2023 09:59
lippserd
lippserd requested changes Feb 2, 2023
View reviewed changes
library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Hook/EmailProviderHook.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/SendForm.php Show resolved Hide resolved
@TAINCER TAINCER requested a review from lippserd February 2, 2023 13:21
@lippserd lippserd removed this from the 1.0.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab Awaiting requested review from yhabteab

@lippserd lippserd Awaiting requested review from lippserd

Requested changes must be addressed to merge this pull request.

Assignees

@TAINCER TAINCER

Labels
cla/signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TAINCER @lippserd @yhabteab