-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded code in config.py and breeze_connect.py to handle values for all instruments in all exchanges. #162
Open
AshutoshBuilds
wants to merge
2
commits into
Idirect-Tech:main
Choose a base branch
from
AshutoshBuilds:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the Stockcode mapping dictionary to access file for FOBSE instruments.
Upgraded get_names function to handle and return values for all the available exchange codes and also for all the available instruments in all the exchanges. This was done because get_names function was only working for NSE and not other exchanges and instruments.
Dear Ashutosh,
Thank you for showing interest in Breeze API.
We will test on our end and will update it.
[E29CF836]
Thanks & Regards,
Akash Sapkal,
Team Breeze API,
ICICI Securities
…________________________________
From: ASHUTOSH SHUKLA ***@***.***>
Sent: 27 November 2024 23:27
To: Idirect-Tech/Breeze-Python-SDK ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [Idirect-Tech/Breeze-Python-SDK] Upgraded code in config.py and breeze_connect.py to handle values for all instruments in all exchanges. (PR #162)
CAUTION: This email originated from outside the organization! Do not click links, open attachments or reply, unless you recognize the sender's email address! Use 'Report suspicious Email' button in the toolbar to report Phishing mails. Beware!
I have upgraded the Stockcode mapping dictionary in config.py to access scrip file for FOBSE and I have upgraded the get_names function in breeze_connect.py to handle and return values for all the available instruments for all the exchanges. This was done because get_names function was only able to work with NSE exchange code but now it works with every available instrument and code.
________________________________
You can view, comment on, or merge this pull request online at:
#162
Commit Summary
* d04b11f<d04b11f> Update config.py
* bea48a6<bea48a6> Update breeze_connect.py
File Changes
(2 files<https://github.com/Idirect-Tech/Breeze-Python-SDK/pull/162/files>)
* M breeze_connect/breeze_connect.py<https://github.com/Idirect-Tech/Breeze-Python-SDK/pull/162/files#diff-dfcfe8a9e274710d6d5f5f7f8b33d070a4f45f0a5ae416f98cc82b697a8f0e19> (135)
* M breeze_connect/config.py<https://github.com/Idirect-Tech/Breeze-Python-SDK/pull/162/files#diff-b2d174491ca96b356bc330e16279967b833bdd0a3fb7293ee0aa1abb3076264c> (7)
Patch Links:
* https://github.com/Idirect-Tech/Breeze-Python-SDK/pull/162.patch
* https://github.com/Idirect-Tech/Breeze-Python-SDK/pull/162.diff
—
Reply to this email directly, view it on GitHub<#162>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3TQZ4664CG2QYTTW7U5Z6D2CYBY5AVCNFSM6AAAAABSTNK4CGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TSMZYGI4TEMQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
Print this mail only if absolutely necessary. Save Paper. Save Trees." "The information contained in this e-mail and any attachments to this message are intended for the exclusive use of the intended recipient and may contain proprietary, confidential or legally privileged information. If you are not the intended recipient, please note that you are not authorised to disseminate, distribute or copy this e-mail or any parts of it or act upon/rely on the contents of this e-mail in any manner. Please notify the sender immediately by e-mail and destroy all copies of this e-mail and any attachments. Please also note that ICICI Bank or its subsidiaries and associated companies, (collectively "ICICI Group"), are unable to exercise control or ensure the integrity of/over the contents of the information contained in e-mail transmissions and that any views expressed in this e-mail are not endorsed by/binding on the ICICI Group unless the sender does so expressly with due authority of ICICI Group. Before opening any attachments please check them for viruses and defects and please note that ICICI Group accepts no liability or responsibility for any damage caused by any virus that may be transmitted by this email. Any unauthorized use of this email or any attachment(s) may be treated as infringement of right(s) including right of privacy under the applicable laws of India including Information and Technology Act, 2000. Thank you for your cooperation. Regulatory Disclosures are available on https://www.icicisecurities.com (for institutional business) and www.icicidirect.com (for retail business).
|
Sure Thanks! |
Hey can I get some update on what's the status about updating the code? Thanks again! |
Dear Ashutosh,
Greetings for the day!
We are working on it and once we are done with the testing we will push it.
[E29CF836]
Thanks & Regards,
Akash Sapkal,
Team Breeze API,
ICICI Securities
…________________________________
From: ASHUTOSH SHUKLA ***@***.***>
Sent: 15 December 2024 23:57
To: Idirect-Tech/Breeze-Python-SDK ***@***.***>
Cc: BREEZEAPI ***@***.***>; Comment ***@***.***>
Subject: Re: [Idirect-Tech/Breeze-Python-SDK] Upgraded code in config.py and breeze_connect.py to handle values for all instruments in all exchanges. (PR #162)
CAUTION: This email originated from outside the organization! Do not click links, open attachments or reply, unless you recognize the sender's email address! Use 'Report suspicious Email' button in the toolbar to report Phishing mails. Beware!
Hey can I get some update on what's the status about updating the code? Thanks again!
—
Reply to this email directly, view it on GitHub<#162 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3TQZ42ZZZNVRCJD7DMHVQD2FXC27AVCNFSM6AAAAABSTNK4CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHE4TCMZVGM>.
You are receiving this because you commented.Message ID: ***@***.***>
Print this mail only if absolutely necessary. Save Paper. Save Trees." "The information contained in this e-mail and any attachments to this message are intended for the exclusive use of the intended recipient and may contain proprietary, confidential or legally privileged information. If you are not the intended recipient, please note that you are not authorised to disseminate, distribute or copy this e-mail or any parts of it or act upon/rely on the contents of this e-mail in any manner. Please notify the sender immediately by e-mail and destroy all copies of this e-mail and any attachments. Please also note that ICICI Bank or its subsidiaries and associated companies, (collectively "ICICI Group"), are unable to exercise control or ensure the integrity of/over the contents of the information contained in e-mail transmissions and that any views expressed in this e-mail are not endorsed by/binding on the ICICI Group unless the sender does so expressly with due authority of ICICI Group. Before opening any attachments please check them for viruses and defects and please note that ICICI Group accepts no liability or responsibility for any damage caused by any virus that may be transmitted by this email. Any unauthorized use of this email or any attachment(s) may be treated as infringement of right(s) including right of privacy under the applicable laws of India including Information and Technology Act, 2000. Thank you for your cooperation. Regulatory Disclosures are available on https://www.icicisecurities.com (for institutional business) and www.icicidirect.com (for retail business).
|
Sure thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have upgraded the Stockcode mapping dictionary in config.py to access scrip file for FOBSE and I have upgraded the get_names function in breeze_connect.py to handle and return values for all the available instruments for all the exchanges. This was done because get_names function was only able to work with NSE exchange code but now it works with every available instrument and code.