Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image capture added #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Image capture added #4

wants to merge 1 commit into from

Conversation

netvandal
Copy link

Hi guys,
I've hacked a bit your project to add the ability to capture and save images.

It's a starting point (setting the resolution could be useful for get decent photos) but i love my hulk pictures

Michele

@magomez
Copy link
Member

magomez commented Apr 23, 2012

Thanks for the patch Michelle!! :)

Besides some comments that I'll inline in the patch code, I think I need to make a comment related to the still picture feature, and that was the main reason why getting pics was not on our scope for Aura: 320x240 is the maximum resolution the hardware can handle in order to apply the effects over the received images. Try something bigger that that and the viewfinder will become slow and a lot of frames will be dropped. You can try it yourself setting the Medium resolution in the code (which is VGA: 640x480).

This 320x240 can be acceptable for video (despite a bit low), but for a pic is too low, and that's we thought that getting pics wasn't really useful, and we still think it isn't.

Anyway, if you feel like like 320x240 is useful for you, we could discuss about applying your patch ;)

@@ -141,6 +142,16 @@ void Controller::stopRecording()
}
}

void Controller::captureImage()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really need to acquire the recording resources in order to get a pic. That's only needed for video because you need to get the audio recording resources. For pics, you already have the camera and the viewfinder since the app gets launched, so you don't need anything else.

@magomez
Copy link
Member

magomez commented Apr 23, 2012

Another comment to the code, not just to a single line but to a concept. Changing mode if the user wants to capture something and we are not in the proper mode doesn't seem like a good idea. It adds an undesired latency before the actual shot happens.
The best way to add the pic feature would be to add a button to change between video/still, and change the capture icon accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants