Fix weekly goal calc if in last week of the year #520
Conversation
There was a problem hiding this comment.
This fixes the error, but provides a result of 0 in the last week of the year which is not correct either. Still, I can't find the way to get the result I would expect!
These weekly goals are extremely cursed and it's hard to understand how they work, the feature should be reworked... But that's a problem for another day, let's fix this failure now.
This would fix #432, would you mind adding the issue number to the commit message? Thanks!
If the week in case is the last week of the year, this method would fail because weeksTillEndOfJourneyPeriod is 0, causing a division by 0 exception Fixes #432
anarute
force-pushed
the
fix-weekly-goal
branch
from
08abb46
to
be434b7
Compare
I was doing some tests and I think we'll need to refactor the whole logic.. it doesn't seem to be generating the expected result. Created #521 for this since fixing the division by zero error is a blocker for me at the moment.
Done |
If the week in case is the last week of the year, this method would fail because weeksTillEndOfJourneyPeriod is 0, causing a division by 0 exception.