Add template endpoint #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrek14
force-pushed
the
add-template-endpoint
branch
2 times, most recently
from
c87e817
to
c80ae4f
Compare
anarute
reviewed
Sep 13, 2023
api/models/timelog.py
Outdated
| customer_id = Column("customerid", Integer, ForeignKey("customer.id"), nullable=True) | ||
| user_id = Column("usrid", Integer, ForeignKey("usr.id"), nullable=True) | ||
| project_id = Column("projectid", Integer, ForeignKey("project.id"), nullable=True) | ||
| is_global = Column(Boolean, nullable=False) |
There was a problem hiding this comment.
I suggest adding default=False, just to make sure no task is global by mistake.
There was a problem hiding this comment.
I had started by removing the telework and onsite columns, but that was going to break some things
dmtrek14
force-pushed
the
add-template-endpoint
branch
from
c80ae4f
to
f071988
Compare
anarute
reviewed
Sep 13, 2023
- Add isGlobal column so that we can store global templates in db - Made usrid nullable since global templates won't belong to single user - Update model for table
- Add service to fetch all user templates plus global templates - Add schema
dmtrek14
force-pushed
the
add-template-endpoint
branch
from
f071988
to
d7d223f
Compare
anarute
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, there are some small changes to the
templatetable to allow for storage of global templates in the database.Second, this adds a GET endpoint to the API to retriever user templates. This will get all templates the user has created as well as all global templates.