Implement user check and start of permissions #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrek14
force-pushed
the
api-check-current-user
branch
from
4a2cd6b
to
ab18eb5
Compare
anarute
requested changes
Sep 27, 2023
dmtrek14
force-pushed
the
api-check-current-user
branch
from
ab18eb5
to
4632aea
Compare
anarute
reviewed
Sep 27, 2023
- Add get_current_user to dependencies that introspects token and builds user info based on username in token - Add config values to indicate use of OIDC roles (passed in token) or roles in local db - Add the user dependency to template endpoints and check user id against logged in user - Update user models and schema as needed - Add user service to get users and user roles
dmtrek14
force-pushed
the
api-check-current-user
branch
from
4632aea
to
3cdfacf
Compare
anarute
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #682 and is an initial implementation of permissions for the API.
Code for the user check based on the examples shown in https://fastapi.tiangolo.com/tutorial/security/simple-oauth2/.