Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST task endpoint #684

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add POST task endpoint #684

merged 1 commit into from
Oct 3, 2023

Conversation

dmtrek14
Copy link
Collaborator

@dmtrek14 dmtrek14 commented Sep 29, 2023

Closes #677

  • Update Pydantic to v2 and make associated syntax changes to several models
  • Add validation, computed fields, and hybrid properties to support task creation
  • Add services and service methods to validate tasks
  • Add/update schemas for tasks

Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are suggestions to start using early returns to decrease nesting and redundant checks.

api/models/timelog.py Outdated Show resolved Hide resolved
api/routers/v1/timelog.py Show resolved Hide resolved
api/routers/v1/timelog.py Outdated Show resolved Hide resolved
api/routers/v1/timelog.py Outdated Show resolved Hide resolved
api/schemas/project.py Show resolved Hide resolved
api/schemas/timelog.py Outdated Show resolved Hide resolved
api/schemas/timelog.py Outdated Show resolved Hide resolved
api/services/config.py Outdated Show resolved Hide resolved
api/services/timelog.py Outdated Show resolved Hide resolved
api/services/timelog.py Outdated Show resolved Hide resolved
@dmtrek14 dmtrek14 force-pushed the task-post-endpoint branch 5 times, most recently from 7fc47b1 to 0b43bdf Compare October 2, 2023 22:41
- Update Pydantic to v2 and make associated syntax changes to several models
- Add validation, computed fields, and hybrid properties to support task creation
- Add services and service methods to validate tasks
- Add/update schemas for tasks
- Add helper for various time-related conversions
Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you for the changes!

@dmtrek14 dmtrek14 merged commit 7f68ec9 into main Oct 3, 2023
1 check passed
@dmtrek14 dmtrek14 deleted the task-post-endpoint branch October 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CREATE endpoint for tasks
2 participants