[OpenTelemetry] Initial local only implementation #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just filter logcat by |
This is a preparation commit for the integration of the opentelemetry-android library into Wolvic that will allow us to know more about users actions and their usage of the different features (obviously with their prior consent). The OpenTelemetry android library requires at least a compilesdk 35 and kotlin 2.1 so let's bump them both. Also we need to enable desugaring for the library to work properly with newer versions of Android. We use a different approach to include new dependencies. Instead of using the custom versions.gradle file, we switched to the more modern library catalog declarations.
This is an initial implementation of the ITelemetry interface using OpenTelemetry, in particular, the opentelemetry-android library. Using this new library forces us to bump the required kotlin version and the project compilesdk version. So far the telemetry data is logged only to the logcat and not sent to any server. In order to avoid too many writes (and in the future to batch requests to the servers) it uses on disk buffering.
svillar
force-pushed
the
opentelemetry
branch
from
880e431 to
854a13d
Compare
javifernandez
approved these changes
Feb 14, 2025
app/src/common/shared/com/igalia/wolvic/telemetry/OpenTelemetry.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FxR used to have telemetry based on glean. We disabled that long time ago and haven't sent any telemetry information to any server since almost the very beginning. However it's very important for us knowing which features of the browser are mostly used in order to focus our scarce resources on those important areas.
We've chosen the OpenTelemetry API because it's flexible enough to support simple use cases (like Wolvic) while being able to be customized at will.
This initial implementation does not send anything to any server yet, it's logging everything to the device logcat but it's the basis for future works.