Use SoundPool API to play sound effects #1791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing the audio files assets we will store them now as raw resources. This will help us moving towards implementing the audio media player to SoundPool. We'd still have to keep the current implementation for Meta devices that do not deal well with SoundPool.
SoundPool provides low-latency playback for Android applications. It's better than MediaPlayer for playing very short clips of audio, like the ones used for sound effects like clicking, typing, etc. Unfortunately Meta devices do not get along well with this API forcing us to keep using MediaPlayer for the oculusvr flavor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much better than MediaPlayer for playing short clips with low latency. Unfortunately not working well in Meta devices so we have to keep the old implementation around