feat(query-builder): support for nested queries and other improvements #14647
Conversation
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…ee change" This reverts commit 98b08df.
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
igdmdimitrov
added
the
🛠️ status: in-development
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The '+' icons in the add "'and'/'or' group" buttons are not displayed. Suggestion: move the registerSVGIcons method to the query-builder.component.ts and call it on initial loading because when there is no expression tree a query-builder-tree is not created and the method is not called |
|
@desig9stein I made a comment in Figma, but i'm adding it here too. These gaps need to be reduced for the following themes (lightt and dark):
|
|
When query builder is used in the dialog mode, the ghost chips are not shown.
P.S. |
I’m unsure of the best approach for handling this. While I could add z-index: 0 and position: relative to the overlay, it doesn’t feel like an appropriate solution. @igdmdimitrov, would it be possible to render the chip ghost inside the P.S. |
…o 16px/1rem for all themes
|
| } @else { | ||
| <ng-container #defaultTemplate *ngTemplateOutlet="defaultSearchValueTemplate"></ng-container> | ||
| } | ||
| </ng-template> |
There was a problem hiding this comment.
Add the drag & drop functionality
|
|
The classes and selectors stings in the drag service should be replaced as suggested in the #15122 - #15122 (comment) |
|
Moved from previous PR: [Bug] "Select All" is not accessible via the keyboard. Open "Return fields" drop down |
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
| @@ -15,6 +16,8 @@ const QueryBuilderResourceStringsIT_: ExpandRequire<IQueryBuilderResourceStrings | |||
| igx_query_builder_filter_notEmpty: 'Non vuoto', | |||
| igx_query_builder_filter_null: 'Null', | |||
| igx_query_builder_filter_notNull: 'Non null', | |||
| igx_query_builder_filter_in: 'In', | |||
| @@ -15,6 +16,8 @@ const QueryBuilderResourceStringsKO_: ExpandRequire<IQueryBuilderResourceStrings | |||
| igx_query_builder_filter_notEmpty: '비우지 않음', | |||
| igx_query_builder_filter_null: 'Null', | |||
| igx_query_builder_filter_notNull: 'Not Null', | |||
| igx_query_builder_filter_in: 'In', | |||
| this.setDragCursor('grab'); | ||
|
|
||
| //TODO z-index is set, but ghost still not visible in Dialog | ||
| if(this.dragGhostElement.style) this.dragGhostElement.style.zIndex = "9999"; |
There was a problem hiding this comment.
DRAG GHOST NOT VISIBLE IN DIALOG
Event after setting the z-index of the drag ghost to 9999, it's still not visible over the dialog.
As you can see, the ghost is rendered as last child of the body, outside app-root and overlay and we don't have control over this:
There was a problem hiding this comment.
Seems that the overlay is with z-index 10005.
That's why 9999was not working. 10006 is...
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts
Outdated
Show resolved
Hide resolved
…component.spec.ts Co-authored-by: Galina Edinakova <[email protected]>
…component.spec.ts Co-authored-by: Galina Edinakova <[email protected]>
projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts
Outdated
Show resolved
Hide resolved
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
Closes #14642
Closes #14979
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)