fix(pivot-grid): added createRow method for grid based events #15209
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishko0
added
❌ status: awaiting-test
skrustev
requested changes
Jan 15, 2025
projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts
Outdated
Show resolved
Hide resolved
…/igniteui-angular into ttonev/fix-14970-master
skrustev
requested changes
Feb 5, 2025
| @@ -791,3 +791,28 @@ export class IgxSummaryRow implements RowType { | |||
| return row; | |||
| } | |||
| } | |||
|
|
|||
| export class IgxPivotGridRow extends BaseRow { | |||
There was a problem hiding this comment.
If you use the BaseRow as a parent class you will need to override the same properties like the IgxPivotRowComponent, which I think the list is longer if you just define the ones you need.
I would mean that you don't extend BaseRow and only implement the RowType and define only:
- index
- grid
- data
- viewIndex
- key
- expanded (I am not sure if we need this one though)
- selected
Also I am not sure you override the cells getter when the implementation is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14970
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)