Skip to content

Commit

Permalink
Fix: version lt bug
Browse files Browse the repository at this point in the history
Igor Gov committed Feb 5, 2022
1 parent a0e6b4d commit 266a610
Showing 2 changed files with 10 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test_version.py
Original file line number Diff line number Diff line change
@@ -85,3 +85,10 @@ def test_get_next_version_special_cases():

tags = ['stable']
assert str(get_next_version(prefix, tags, "major")) == '0.0'

def test_get_next_version_unsorted():
prefix = "dev"
tags = ['26.0', '26.0-dev0']

assert str(get_next_version(prefix, tags, "increment")) == '27.0-dev0'
assert str(get_next_version(prefix, tags, "major")) == '27.0'
3 changes: 3 additions & 0 deletions version.py
Original file line number Diff line number Diff line change
@@ -59,6 +59,8 @@ def __eq__(self, other) -> bool:
def __lt__(self, other) -> bool:
if self.is_dev() and other.is_dev():
return (self.major, self.patch, self.increment) < (other.major, other.patch, other.increment)
elif self.is_dev() and not other.is_dev():
return (self.major, self.patch) <= (other.major, other.patch)
else:
return (self.major, self.patch) < (other.major, other.patch)

@@ -92,5 +94,6 @@ def get_next_version(suffix: str, tags: list[str], release_type: str) -> Version
last_version = get_most_recent_release(versions)
else:
last_version = get_most_recent_official_release(versions)
print(f'most recent release version {last_version}')
next_version = get_next(last_version, release_type)
return next_version

0 comments on commit 266a610

Please sign in to comment.