Add unsubscribe option #5
Conversation
| <hr> | ||
| <hr> | ||
|
|
||
| <h3>Unsubscribe : (</h2> |
There was a problem hiding this comment.
Unsubscribe :
could you please remove the blank space before the :?
| @@ -92,4 +92,6 @@ | |||
| :domain => 'heroku.com', | |||
| :enable_starttls_auto => true | |||
| } | |||
|
|
|||
| config.action_mailer.default_url_options = { :host => "your-weekly-production.herokuapp.com" } | |||
There was a problem hiding this comment.
Why do we need this? The app already works fine today.
There was a problem hiding this comment.
It's for the link_to, it needs the host parameter to build the url
| @@ -17,6 +17,24 @@ def create | |||
| end | |||
| end | |||
|
|
|||
| def unsubscribe | |||
There was a problem hiding this comment.
Could you please extract this action and the cancel_subscription to another controller? This one is turning a little cumbersome.
There was a problem hiding this comment.
Like an unsubscribe controller?
| end | ||
| end | ||
|
|
||
| def cancel_subscription |
There was a problem hiding this comment.
I think a better name here would be confirm unsubscribing or something like it. Just by the name is a little hard to differ from the one above (unsubscribe).
There was a problem hiding this comment.
Yeah, i felt the same thing about the naming
For the hacktoberfest 😛