Upcoming events page #338
Upcoming events page #338
Conversation
There was a problem hiding this comment.
Great start! I made a few comments (most are trivial) on the code itself, but one thing i wanted to bring up was that maybe we can anchor some parts of the events to sides of the box to keep consistent padding. I know this might be a lot so let me know if you have any questions about anything!
what we currently have
what we want
There was a problem hiding this comment.
(@BeckyBlake tagging you here too)
Looks good, a couple things to add:
- can you make sure that when we click on the red dot we close out the modal as well (to keep in line with what we've been doing so far)
- could the lines here be a little less padded:
| @@ -1,11 +1,16 @@ | |||
| .container { | |||
| color: black; | |||
| display: flex; | |||
| gap: 0.5rem; | |||
| /* gap: 0.5rem; */ | |||
There was a problem hiding this comment.
you can removew the commented code
| } | ||
|
|
||
| .hiddenButton { | ||
| border: none; | ||
| background-color: transparent; | ||
| /* added */ | ||
| width: 100%; |
There was a problem hiding this comment.
remove added comments before committing
| topbarColor = '#65C7CC', | ||
| buttonColor = '#CBEDFF', | ||
| topbarColor = 'var(--wcs-blue)', | ||
| buttonColor = '#D1EEEF', |
There was a problem hiding this comment.
this color should be var(light-blue)
| @@ -125,16 +121,19 @@ | |||
| .eventContainer { | |||
| padding: 3.75rem; | |||
| } | |||
|
|
|||
| .pastEventsButtonText { | |||
| font-size: 20px; | |||
There was a problem hiding this comment.
just as a note, we would ideally not want to use px here, and instead use either built in h1/h2 etc or use a more responsive sizing. It is fine for right now, but we'll be working on adding responsiveness later, so a good think to keep note of.
Status:
Description
I edited the upcoming events page to make the modals structured properly and of a proper size. I made the dates and day of week formatted properly.
Screenshots