Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing argument namespace issue introduced with hguturu:hg-fix-pre-convert-gvcf #135

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

nate-d-olson
Copy link

Fixing issue with args.convert_gvcf_truth missing from namespace in verion 0.3.13, described in #113 (comment).

To fix the issue I added --convert-gvcf-truth and --convert-gvcf-query arguments to hap.py.
Potential issue with hap.py having both --convert-to-vcf and --convert-gvcf-[truth|query].
Added conditional statement and defining new variables convert_gvcf_truth and convert_gvcf_query so that the gvcf to vcf conversion is performed if either convert_gvcf_to_vcf or convert_gvcf_[truth|query] flags are used.

Please merge this pull request, or another fix, and release a new version for snakemake/snakemake-wrappers#294.

@nate-d-olson
Copy link
Author

Can we get this merged and released, or another kind of fix for this issue, please? Fixing this is a priority for the GIAB project.

Copy link
Contributor

@dskola dskola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants